what is a good friend

so this guy i know told his best friend to give up on his dream job because he sucks at it. they both do the same kind of work. is it his duty as 'best friend' to encourage and help his buddy be better or is he right to tell him to stop?

are good friends the ones that encourage you or the ones that tell you when you fail?